Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PULUMI_K8S_ENABLE_PATCH_FORCE env var support #2260

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Dec 9, 2022

Proposed changes

PULUMI_K8S_ENABLE_PATCH_FORCE="true" pulumi up --target="**DeploymentPatch::example"
Previewing update (dev)

View Live: https://app.pulumi.com/lblackstone/pulumi-k8s-test/dev/previews/2fc3fde8-3420-4e39-ae23-196f6bfd4164

     Type                                   Name                 Plan
     pulumi:pulumi:Stack                    pulumi-k8s-test-dev
 +   └─ kubernetes:apps/v1:DeploymentPatch  example              create


Resources:
    + 1 to create
    3 unchanged

Do you want to perform this update? yes
Updating (dev)

View Live: https://app.pulumi.com/lblackstone/pulumi-k8s-test/dev/updates/369

     Type                                   Name                 Status
     pulumi:pulumi:Stack                    pulumi-k8s-test-dev
 +   └─ kubernetes:apps/v1:DeploymentPatch  example              created (0.23s)


Resources:
    + 1 created
    3 unchanged

Duration: 1s

Fix #2259

Related issues (optional)

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

return true
}
if enabled, exists := os.LookupEnv("PULUMI_K8S_ENABLE_PATCH_FORCE"); exists {
return enabled == "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Might be nice if the value could be any case or 1 (i.e. "truthy"), but I wouldn't block on it, this is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I followed precedence for other env vars on this provider, but it would be a nice thing to change. I'll open an issue to follow up on that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lblackstone lblackstone merged commit d4b04c7 into master Dec 14, 2022
@lblackstone lblackstone deleted the lblackstone/patchforce branch December 14, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose SSA patchForce option as an env var
2 participants