Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for __inputs secrets #2300 #2301

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Fix for __inputs secrets #2300 #2301

merged 7 commits into from
Feb 6, 2023

Commits on Feb 3, 2023

  1. Speculative fix for __inputs secrets #2300 

    checkpointObject checks for secrets in the input, but in this case
the input is of Kind=="Secret" but ContainsSecret() is false.

I'm not quite sure yet that this is the best fix but it works in my
local repro.
    @thomas11
    thomas11 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    92fe8f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Satisfy silly 'duplicate strings' linter

    @thomas11
    thomas11 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    cd33976 View commit details
    Browse the repository at this point in the history

  2. Add VS Code to gitignore

    @thomas11
    thomas11 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    fc241f4 View commit details
    Browse the repository at this point in the history

  3. Move check into annotateSecrets, add test

    @thomas11
    thomas11 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    ddb1767 View commit details
    Browse the repository at this point in the history

  4. Also encrypt annotations in the secret kind case

    @thomas11
    thomas11 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    962a191 View commit details
    Browse the repository at this point in the history

  5. Also encrypt stringData if present

    @thomas11
    thomas11 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    1d918a7 View commit details
    Browse the repository at this point in the history

  6. Update CHANGELOG

    @thomas11
    thomas11 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    361eb7d View commit details
    Browse the repository at this point in the history