chore: Update Pulumi Java SDK to v0.8.0 #2337
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
| @@ -123,7 +123,7 @@ javadoc { | |||
| if (JavaVersion.current().isJava9Compatible()) { | |||
| options.addBooleanOption('html5', true) | |||
| } | |||
| options.jFlags("-Xmx2g", "-Xms512m") | |||
| options.jFlags("-Xmx8g", "-Xms512m") | |||
There was a problem hiding this comment.
can we rely on having that much on CI runners?
There was a problem hiding this comment.
Assume this will just act as unbounded and will fail if the host won't give it more memory - this is only the max and not the inital memory to be reserved?
There was a problem hiding this comment.
Is the extra memory required? I'm not opposed to the change, but curious what the motivation is.
There was a problem hiding this comment.
Think this is generated by the java language - was increased because some providers (probably AWS or Azure) crash with only 2gb
There was a problem hiding this comment.
Yes, these changes come from upstream (in the make build, particularly, building the Java sdk step) when we updated to the latest Java gen version. Xmx indicates the maximum allowed, so it won't fail on start, only if the program requires more and the host can't allocate it.
|
This looks like it takes the form
|
Fixes #2333
Steps carried out in this PR:
make build