Fix: Python SDK: kustomize.Directory: handle a not fully configured provider #2347
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
Hi @filip-zyzniewski - thank you so much for your contribution here! It looks like this fix was implemented directly in the Python SDK. Those files are autogenerated from two sources - one is the K8s API spec, and the other is from overlays defined in this repo. If you could re-implement this fix in this file here: |
Per pulumi#2347 (comment) Result of: ```console pulumi-kubernetes $ cp sdk/python/pulumi_kubernetes/kustomize/kustomize.py provider/pkg/gen/python-templates/kustomize/kustomize.py pulumi-kubernetes $ make python_sdk [...] pulumi-kubernetes $ ``` Fixes: pulumi#2346
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
|
/run-acceptance-tests |
|
Please view the PR build: https://github.com/pulumi/pulumi-kubernetes/actions/runs/4610359420 |
|
Awesome @filip-zyzniewski - this is looking great! One final ask - would you mind adding an entry to Thank you again! |
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
/run-acceptance-tests |
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
Please view the PR build: https://github.com/pulumi/pulumi-kubernetes/actions/runs/4640368250 |
|
@filip-zyzniewski - the change looks good, all tests are passing, and we have a changelog entry! ✅ Going to get this merged now, and it'll be available in our next release. |
Proposed changes
When the kubernetes provider is not fully configured (https://github.com/pulumi/pulumi/blob/v3.60.1/sdk/go/common/resource/plugin/provider_plugin.go#L1364-L1367), then the
valueproperty of theInvokeResultinstance isNone.This PR attempts to add handling of this case.
Related issues (optional)
Fixes #2346