Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove imperative auth API resources #2413

Merged
merged 13 commits into from May 17, 2023
Merged

Remove imperative auth API resources #2413

merged 13 commits into from May 17, 2023

Conversation

rquitales
Copy link
Contributor

@rquitales rquitales commented May 16, 2023 •
edited by lblackstone

#2412 surfaced some resources that were not declarative Kubernetes resources that could be managed by Pulumi. Instead, these were imperative API endpoints that returned time-sensitive tokens. This PR removes these resources. Instead, users should do something like: <pulumi_command> + kubectl create token for this CUJ.

Resources removed:

  • LocalSubjectAccessReview
  • SelfSubjectAccessReview
  • SelfSubjectReview
  • SelfSubjectRulesReview
  • SubjectAccessReview
  • TokenRequest
  • TokenReview

@rquitales rquitales requested review from lblackstone and a team May 16, 2023 17:59
lblackstone
lblackstone requested changes May 16, 2023
View reviewed changes
provider/pkg/gen/typegen.go Outdated Show resolved Hide resolved
provider/pkg/gen/typegen.go Outdated Show resolved Hide resolved
@rquitales
Copy link
Contributor Author

@lblackstone This is ready for a second-pass. Have removed the other API versions for TokenReview, and SelfSubjectReview.

@github-actions
Copy link

Does the PR have any schema changes?

Found 10 breaking changes:
Resource "kubernetes:authentication.k8s.io/v1alpha1:SelfSubjectReview" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:TokenReviewPatch" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenRequestPatch" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenReview" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:SelfSubjectReviewPatch" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenReviewPatch" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:TokenReview" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:SelfSubjectReview" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenRequest" missing
Resource "kubernetes:authentication.k8s.io/v1alpha1:SelfSubjectReviewPatch" missing
No new resources/functions.

lblackstone
lblackstone reviewed May 16, 2023
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments, and then LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@pulumi pulumi deleted a comment from github-actions bot May 17, 2023
@pulumi pulumi deleted a comment from github-actions bot May 17, 2023
@pulumi pulumi deleted a comment from github-actions bot May 17, 2023
@github-actions
Copy link

Does the PR have any schema changes?

Found 24 breaking changes:
Resource "kubernetes:authentication.k8s.io/v1:TokenReview" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:TokenReview" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenRequestPatch" missing
Resource "kubernetes:authentication.k8s.io/v1alpha1:SelfSubjectReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SubjectAccessReview" missing
Resource "kubernetes:authorization.k8s.io/v1:SelfSubjectRulesReview" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SubjectAccessReview" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SubjectAccessReviewPatch" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SubjectAccessReviewPatch" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:SelfSubjectReview" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:LocalSubjectAccessReview" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:LocalSubjectAccessReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:LocalSubjectAccessReview" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SelfSubjectAccessReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SelfSubjectAccessReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SelfSubjectAccessReview" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenRequest" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:TokenReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SelfSubjectAccessReview" missing
Resource "kubernetes:authentication.k8s.io/v1alpha1:SelfSubjectReview" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:SelfSubjectReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SelfSubjectRulesReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:LocalSubjectAccessReviewPatch" missing
No new resources/functions.

@pulumi pulumi deleted a comment from github-actions bot May 17, 2023
@lblackstone lblackstone changed the title Remove imperative authentication/v1 API resources Remove imperative auth API resources May 17, 2023
@github-actions
Copy link

Does the PR have any schema changes?

Found 26 breaking changes:
Resource "kubernetes:authentication.k8s.io/v1beta1:SelfSubjectReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SelfSubjectRulesReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SelfSubjectAccessReview" missing
Resource "kubernetes:authorization.k8s.io/v1:SelfSubjectAccessReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:LocalSubjectAccessReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SelfSubjectAccessReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:LocalSubjectAccessReview" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenReview" missing
Resource "kubernetes:authentication.k8s.io/v1alpha1:SelfSubjectReviewPatch" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenRequest" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:LocalSubjectAccessReviewPatch" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:TokenReview" missing
Resource "kubernetes:authorization.k8s.io/v1:LocalSubjectAccessReview" missing
Resource "kubernetes:authentication.k8s.io/v1alpha1:SelfSubjectReview" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenRequestPatch" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SubjectAccessReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SelfSubjectAccessReview" missing
Resource "kubernetes:authorization.k8s.io/v1:SubjectAccessReview" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:SelfSubjectReview" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SubjectAccessReview" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SelfSubjectRulesReview" missing
Resource "kubernetes:authorization.k8s.io/v1beta1:SelfSubjectRulesReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SelfSubjectRulesReview" missing
Resource "kubernetes:authentication.k8s.io/v1beta1:TokenReviewPatch" missing
Resource "kubernetes:authorization.k8s.io/v1:SubjectAccessReviewPatch" missing
Resource "kubernetes:authentication.k8s.io/v1:TokenReviewPatch" missing
No new resources/functions.

@lblackstone lblackstone enabled auto-merge (squash) May 17, 2023 21:16
@lblackstone lblackstone merged commit 92789b8 into master May 17, 2023
18 checks passed
@lblackstone lblackstone deleted the rquitales/tokenrequest branch May 17, 2023 21:16
@rquitales rquitales mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rquitales @lblackstone