Drop support for Kubernetes clusters older than v1.13 #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, something about this change broke preview in one of the .NET tests. Working to track that down. |
kpitzen
approved these changes
May 17, 2023
lblackstone
force-pushed
the
lblackstone/upgrade-client
branch
3 times, most recently
from
1eff379
to
873e0f8
Compare
rquitales
approved these changes
May 17, 2023
|
@rquitales I'm waiting to see if the tests pass, and then may pull the |
lblackstone
force-pushed
the
lblackstone/upgrade-client
branch
from
04ee4d7
to
b4b62f8
Compare
Does the PR have any schema changes?Found 2 breaking changes: |
|
Tests are passing now, but I'm going to pull the |
As part of upgrading the client-go dependency, we need to drop support for Kubernetes versions older than v1.13.0 (released December 2018, EOL as of October 2019). client-go has dropped support [1] for the dry-run verifier because all cluster versions v1.13 and greater include this support. As a result, we drop the dry run check from the provider, and enforce a minimum version of v1.13. Additionally, one of the options for kustomize support moved [2], so update the calling code to match. [1] kubernetes/kubernetes#114294 [2] kubernetes-sigs/kustomize#4945
lblackstone
force-pushed
the
lblackstone/upgrade-client
branch
from
a251955
to
c9e56a8
Compare
lblackstone
added a commit
that referenced
this pull request
Jul 14, 2023
As part of upgrading the client-go dependency, we need to drop support for Kubernetes versions older than v1.13.0 (released December 2018, EOL as of October 2019). client-go has dropped support [1] for the dry-run verifier because all cluster versions v1.13 and greater include this support. As a result, we drop the dry run check from the provider, and enforce a minimum version of v1.13. Additionally, one of the options for kustomize support moved [2], so update the calling code to match. [1] kubernetes/kubernetes#114294 [2] kubernetes-sigs/kustomize#4945
lblackstone
added a commit
that referenced
this pull request
Jul 17, 2023
As part of upgrading the client-go dependency, we need to drop support for Kubernetes versions older than v1.13.0 (released December 2018, EOL as of October 2019). client-go has dropped support [1] for the dry-run verifier because all cluster versions v1.13 and greater include this support. As a result, we drop the dry run check from the provider, and enforce a minimum version of v1.13. Additionally, one of the options for kustomize support moved [2], so update the calling code to match. [1] kubernetes/kubernetes#114294 [2] kubernetes-sigs/kustomize#4945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As part of upgrading the client-go dependency, we need to drop support for Kubernetes versions older than v1.13.0 (released December 2018, EOL as of October 2019). client-go has dropped support [1] for the dry-run verifier because all cluster versions v1.13 and greater include this support. As a result, we drop the dry run check from the provider, and enforce a minimum version of v1.13.
Additionally, one of the options for kustomize support moved [2], so update the calling code to match.
[1] kubernetes/kubernetes#114294
[2] kubernetes-sigs/kustomize#4945
Related issues (optional)
Fix #2386