Make all resource output properties required #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Found 2 breaking changes: |
kpitzen
reviewed
May 23, 2023
lblackstone
force-pushed
the
lblackstone/required-props
branch
from
12fb92a
to
a69c194
Compare
Previously, the resource properties were not represented consistently across all Pulumi SDKs. In particular, the .NET and NodeJS SDKs represented all resource output properties as required, while Go, Python, and Java represented them as optional. This inconsistency causes problems for multi-language features and documentation. This change unifies all SDKs to mark every top-level resource output as a required property.
lblackstone
force-pushed
the
lblackstone/required-props
branch
from
a69c194
to
f96f560
Compare
kpitzen
approved these changes
May 24, 2023
lblackstone
added a commit
that referenced
this pull request
Jul 14, 2023
Previously, the resource properties were not represented consistently across all Pulumi SDKs. In particular, the .NET and NodeJS SDKs represented all resource output properties as required, while Go, Python, and Java represented them as optional. This inconsistency causes problems for multi-language features and documentation. This change unifies all SDKs to mark every top-level resource output as a required property.
lblackstone
added a commit
that referenced
this pull request
Jul 14, 2023
Previously, the resource properties were not represented consistently across all Pulumi SDKs. In particular, the .NET and NodeJS SDKs represented all resource output properties as required, while Go, Python, and Java represented them as optional. This inconsistency causes problems for multi-language features and documentation. This change unifies all SDKs to mark every top-level resource output as a required property.
lblackstone
added a commit
that referenced
this pull request
Jul 17, 2023
Previously, the resource properties were not represented consistently across all Pulumi SDKs. In particular, the .NET and NodeJS SDKs represented all resource output properties as required, while Go, Python, and Java represented them as optional. This inconsistency causes problems for multi-language features and documentation. This change unifies all SDKs to mark every top-level resource output as a required property.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, the resource properties were not represented consistently across all Pulumi SDKs. In particular, the .NET and NodeJS SDKs represented all resource output properties as required, while Go, Python, and Java represented them as optional. This inconsistency causes problems for multi-language features and documentation.
This change unifies all SDKs to mark every top-level resource output as a required property.
Related issues (optional)
Fix #1650