Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provider handling of CustomResources with Patch suffix #2438

Merged
merged 5 commits into from
Jun 6, 2023

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Jun 5, 2023

Proposed changes

Use a lookup table of QualifiedType strings for Patch URNs rather than the "Patch" suffix to determine if a resource is a Patch resource.

Related issues (optional)

Fix #2433

@lblackstone lblackstone requested a review from a team June 5, 2023 16:20
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link
Contributor

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good on first pass! Would you be able to add 1-2 more test cases to verify this flow?

Copy link
Contributor

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lblackstone lblackstone merged commit 6efe186 into master Jun 6, 2023
17 checks passed
@lblackstone lblackstone deleted the lblackstone/patch-id branch June 6, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CustomResource is treated as a patch resources based on CR name
2 participants