Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for legacy pulumi.com/initialApiVersion annotation #2443

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

lblackstone
Copy link
Member

Proposed changes

The pulumi.com/initialApiVersion annotation was briefly used to store information about the apiVersion used to create each resource in early versions of the provider (v1.x). The logic was updated to store this information in the Pulumi state rather than directly on the resource. Subsequent versions of the provider continued to support this annotation as a fallback option in case the state did not contain this information.

Drop support for the annotation to simplify the provider logic.

Related issues (optional)

Fix #2442

The pulumi.com/initialApiVersion annotation was briefly used to store information about the apiVersion used to create each resource in early versions of the provider (v1.x). The logic was updated to store this information in the Pulumi state rather than directly on the resource. Subsequent versions of the provider continued to support this annotation as a fallback option in case the state did not contain this information.

Drop support for the annotation to simplify the provider logic.
@lblackstone lblackstone requested a review from a team June 6, 2023 19:46
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Does the PR have any schema changes?

Found 2 breaking changes:
Resource "kubernetes:helm.sh/v2:Chart" missing
Type "kubernetes:helm.sh/v2:FetchOpts" missing
No new resources/functions.

@lblackstone lblackstone merged commit 4aed225 into v4 Jun 6, 2023
16 checks passed
@lblackstone lblackstone deleted the lblackstone/drop-legacy-initial-api-version branch June 6, 2023 20:15
@lblackstone

This comment was marked as outdated.

lblackstone added a commit that referenced this pull request Jul 14, 2023
The pulumi.com/initialApiVersion annotation was briefly used to store information about the apiVersion used to create each resource in early versions of the provider (v1.x). The logic was updated to store this information in the Pulumi state rather than directly on the resource. Subsequent versions of the provider continued to support this annotation as a fallback option in case the state did not contain this information.

Drop support for the annotation to simplify the provider logic.
lblackstone added a commit that referenced this pull request Jul 14, 2023
The pulumi.com/initialApiVersion annotation was briefly used to store information about the apiVersion used to create each resource in early versions of the provider (v1.x). The logic was updated to store this information in the Pulumi state rather than directly on the resource. Subsequent versions of the provider continued to support this annotation as a fallback option in case the state did not contain this information.

Drop support for the annotation to simplify the provider logic.
lblackstone added a commit that referenced this pull request Jul 17, 2023
The pulumi.com/initialApiVersion annotation was briefly used to store information about the apiVersion used to create each resource in early versions of the provider (v1.x). The logic was updated to store this information in the Pulumi state rather than directly on the resource. Subsequent versions of the provider continued to support this annotation as a fallback option in case the state did not contain this information.

Drop support for the annotation to simplify the provider logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants