-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul logic for resource diffing #2445
Merged
Merged
Commits on Jun 15, 2023
-
Drop usage of last-applied-configuration annotation
Previous versions of the provider used the "kubectl.kubernetes.io/last-applied-configuration" annotation to store a copy of the configuration as part of the Kubernetes resource. This annotation was used for input diff computation in client-side apply mode. Specifically, input diffs were computed between the new inputs and the last-applied-configuration value from the previous live state. Using this annotation resulted in a large number of reported issues (30+) for the provider, and it will no longer be used. 14916d3 added logic to prune a map based on a target map. This logic is used to prune live state to match the previous inputs before performing an input diff computation. This avoids the need to store the last-applied-configuration.
Configuration menu - View commit details
-
Copy full SHA for 1f1adb4 - Browse repository at this point
Copy the full SHA 1f1adb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34d6a84 - Browse repository at this point
Copy the full SHA 34d6a84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17b7ac8 - Browse repository at this point
Copy the full SHA 17b7ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12c21a5 - Browse repository at this point
Copy the full SHA 12c21a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1916a8 - Browse repository at this point
Copy the full SHA a1916a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5c2944 - Browse repository at this point
Copy the full SHA a5c2944View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7700d85 - Browse repository at this point
Copy the full SHA 7700d85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e87822 - Browse repository at this point
Copy the full SHA 6e87822View commit details
Commits on Jun 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ccf4e41 - Browse repository at this point
Copy the full SHA ccf4e41View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.