-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest helm dependency #2474
Conversation
Does the PR have any schema changes?Found 2 breaking changes: |
590c4c3
to
f10e7ca
Compare
Just added a commit to bump k8s to v1.27 for the test cluster. It seems like the client libraries being upgraded here is causing some diffing issues when the test cluster used is |
Did more testing, and the test fails on OSS Kubernetes (KinD) and not just GKE. Tested:
Looks like this upgrade is causing a regression for all clusters with v1.24 or lower. @lblackstone What do you think about landing this change? |
This PR causes a regression in older clusters.
Pull request was converted to draft
Lets hold off for now. This change isn't required at this time, so let's figure out what's causing the regression and we can ideally wait until it's fixed upstream. |
a1630e9
to
a60992c
Compare
I believe that I identified and fixed the problem causing the test failures. The updated client-go dependency no longer includes dry-run verifier support, and my initial change erroneously changed the support check to use the wrong verifier flag. As a result, the I updated the dry-run support check to require cluster version of v1.13+ rather than querying the cluster, and verified that the test passes again. |
This was reviewed prior to latest changes that addresses the dry-run logic change.
We decided to move this change to the v4 branch, which already drops support for clusters older than v1.13. I'll rework the PR for that. |
a60992c
to
4445c79
Compare
@rquitales Mind giving this another look? |
* Upgrade to latest helm dependency * Remove dry-run verifier code
* Upgrade to latest helm dependency * Remove dry-run verifier code
* Upgrade to latest helm dependency * Remove dry-run verifier code
Proposed changes
Related issues (optional)