Skip wait for Pods on headless Service #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
The await logic for Service resources normally waits for selected Pods to be ready before marking the Service ready. This doesn't work correctly for StatefulSet resources, which use a "headless" Service (i.e., Service without a ClusterIP) to reference its Pods. This led to a circular dependency if the StatefulSet referenced the Service name in the Pulumi program, because the StatefulSet would not be created until after the Service was ready, but the Service was waiting on the StatefulSet to create Pods. This change fixes this dependency by skipping the Pod check for any headless Service, rather than only headless Services that don't have Pods selected.
lblackstone
force-pushed
the
lblackstone/headless-svc
branch
from
4b77b87
to
788fb9f
Compare
rquitales
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The await logic for Service resources normally waits for selected Pods to be ready before marking the Service ready. This doesn't work correctly for StatefulSet resources, which use a "headless" Service (i.e., Service without a ClusterIP) to reference its Pods. This led to a circular dependency if the StatefulSet referenced the Service name in the Pulumi program, because the StatefulSet would not be created until after the Service was ready, but the Service was waiting on the StatefulSet to create Pods. This change fixes this dependency by skipping the Pod check for any headless Service, rather than only headless Services that don't have Pods selected.
Related issues (optional)
Fix #1974
Fix #1995
Related #2001