Gracefully handle undefined resource schemes #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provider includes normalization logic that converts Unstructured resource definitions to their typed equivalents and back. This conversion process requires a defined scheme, and will not work for extension resource types (CRDs, CustomResources, apiregistration, etc). If the scheme is not registered, skip this process rather than returning an error.
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
Consider adding a quick test, perhaps a unit test will do here? |
aq17
approved these changes
Jul 19, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The provider includes normalization logic that converts Unstructured resource definitions to their typed equivalents and back. This conversion process requires a defined scheme, and will not work for extension resource types (CRDs, CustomResources, apiregistration, etc). If the scheme is not registered, skip this process rather than returning an error.
Related issues (optional)
Fix #2503