fix: do not hit API Server for CSA preview #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
force-pushed
the
rquitales/fix-preview
branch
from
48fbf6f
to
cd2de64
Compare
rquitales
commented
Aug 2, 2023
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
reviewed
Aug 7, 2023
|
Looks like we hit another test flake. Opened #2525 to track |
When attempting a preview, do not query against the live cluster if CSA mode is specified. For SSA mode, wrap authentication error with helpful message.
rquitales
force-pushed
the
rquitales/fix-preview
branch
from
49de672
to
85c29e0
Compare
|
@lblackstone This is ready for another pass! |
lblackstone
reviewed
Aug 10, 2023
lblackstone
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting a preview, do not query against the live cluster if CSA mode is specified. For SSA mode, do not return an error if there are authentication issues, and fall back to CSA preview instead.
The
TestServerSideApplyPreviewtest is also removed as impersonation was not actually done correctly. This test is now superseded newly addedTestPreviewtest. This test case creates a new restricted SA and uses it to ensure that the provider falls back to CSA preview when SSA preview hits an auth issue.Fixes #2521