Added skipUpdateUnreachable flag #2528
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. |
1 similar comment
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
H @lblackstone are there any updates on this? What do you think? |
|
Hi @raelix. Thanks for the PR. It looks good from my perspective, but I don't have a lot of context on |
|
/run-acceptance-tests |
|
Please view the PR build: https://github.com/pulumi/pulumi-kubernetes/actions/runs/6005865779 |
|
Hi @iwahbe thanks! Do you have any idea/updates about this changes? Thanks :) |
|
@raelix Apologies for the delays on getting this reviewed - I have been OOO for a bit. This change mostly looks good to me, though I'm hesitant on merging an external API change without testing despite the feature being gated. I'll re-work this PR and hopefully land this soon. |
rquitales
force-pushed
the
skip-update-unreachable
branch
from
7f871b3
to
2f1acec
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
/run-acceptance-tests |
|
Please view the PR build: https://github.com/pulumi/pulumi-kubernetes/actions/runs/6177214323 |
|
thanks a lot @rquitales and @EronWright ! |
|
This is now available in the v4.2.0 release of the provider. |
Proposed changes
The Pulumi
deleteUnreachableflag is great when a cluster is removed but there is no way to proceed with applying the changes on multiple K8s clusters if there is just one not available, in this case the full update will fail (.e.g updating charts over multiple K8s clusters where 1+ are not currently available).The proposed feature introduce a new variable called
skipUpdateUnreachableand allow to runpulumi upwithout failing if one or more Kubernetes cluster are unreachable (showing warning messages).The feature allows to make changes on an existing system which might consist of multiple K8 clusters and at that specific moment has some clusters down.
Related issues (optional)
Fixes: #2565