-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix helm.v3.Release replace behavior #2532
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
The diff logic for the helm.v3.Release resource was intended to replace the resource if the name or namespace changed. However, the names of the fields were incorrect, so the provider was erroneously choosing to update rather than replace the resource. Update the fields to the correct names so that the resource is replaced as intended.
5027730
to
f99982e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also use kubectl to verify that the namespace change occurs as well? Iirc in the original issue, Pulumi will report that ns changes, but the resources do not actually get created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR re-opens #2426, which was already a regression previously. |
Proposed changes
The diff logic for the helm.v3.Release resource was intended to replace the resource if the name or namespace changed. However, the names of the fields were incorrect, so the provider was erroneously choosing to update rather than replace the resource. Update the fields to the correct names so that the resource is replaced as intended.
Related issues (optional)
Fix #2509