Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm.v3.Release replace behavior #2532

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Aug 10, 2023

Proposed changes

The diff logic for the helm.v3.Release resource was intended to replace the resource if the name or namespace changed. However, the names of the fields were incorrect, so the provider was erroneously choosing to update rather than replace the resource. Update the fields to the correct names so that the resource is replaced as intended.

Related issues (optional)

Fix #2509

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

The diff logic for the helm.v3.Release resource was intended to replace the resource if the name or namespace changed. However, the names of the fields were incorrect, so the provider was erroneously choosing to update rather than replace the resource. Update the fields to the correct names so that the resource is replaced as intended.
@lblackstone lblackstone force-pushed the lblackstone/helm-release-namespace branch from 5027730 to f99982e Compare August 11, 2023 18:15
@lblackstone lblackstone marked this pull request as ready for review August 11, 2023 18:15
Copy link
Contributor

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also use kubectl to verify that the namespace change occurs as well? Iirc in the original issue, Pulumi will report that ns changes, but the resources do not actually get created.

Copy link
Contributor

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lblackstone lblackstone enabled auto-merge (squash) August 11, 2023 21:52
@lblackstone lblackstone merged commit 51b8992 into master Aug 11, 2023
18 checks passed
@lblackstone lblackstone deleted the lblackstone/helm-release-namespace branch August 11, 2023 22:38
@ffMathy
Copy link

ffMathy commented Aug 24, 2023

This PR re-opens #2426, which was already a regression previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Release - Changing Provided Namespace Deletes but Does not Recreate Resources
3 participants