Fix helm.v3.Release replace behavior #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
The diff logic for the helm.v3.Release resource was intended to replace the resource if the name or namespace changed. However, the names of the fields were incorrect, so the provider was erroneously choosing to update rather than replace the resource. Update the fields to the correct names so that the resource is replaced as intended.
lblackstone
force-pushed
the
lblackstone/helm-release-namespace
branch
from
5027730
to
f99982e
Compare
rquitales
requested changes
Aug 11, 2023
|
This PR re-opens #2426, which was already a regression previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The diff logic for the helm.v3.Release resource was intended to replace the resource if the name or namespace changed. However, the names of the fields were incorrect, so the provider was erroneously choosing to update rather than replace the resource. Update the fields to the correct names so that the resource is replaced as intended.
Related issues (optional)
Fix #2509