Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Release detect changes to local chart #2568

Merged
merged 9 commits into from
Sep 17, 2023
Merged

Helm Release detect changes to local chart #2568

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c7cc0c2
Compute a checksum of template output
EronWright Sep 13, 2023
9a43409
Avoid spurious release
EronWright Sep 14, 2023
7c5cd1e
Test for helmv3:Release with local chart updates
EronWright Sep 14, 2023
b334937
CHANGELOG
EronWright Sep 14, 2023
47637f5
Remove optimization for migration case
EronWright Sep 15, 2023
995b110
Rename a test case for clarity
EronWright Sep 15, 2023
bb5dd61
Calculate checksum during import
EronWright Sep 15, 2023
3ac46f7
support for ignoreChanges
EronWright Sep 15, 2023
523e22a
integration test for ignorechanges support
EronWright Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions provider/pkg/provider/helm_release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,13 @@ func (r *helmReleaseProvider) Diff(ctx context.Context, req *pulumirpc.DiffReque
// Extract old inputs from the `__inputs` field of the old state.
oldInputs, _ := parseCheckpointRelease(olds)

// apply ignoreChanges
for _, ignore := range req.GetIgnoreChanges() {
if ignore == "checksum" {
news["checksum"] = oldInputs["checksum"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a testcase here for this functionality as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}
}

// Calculate the diff between the old and new inputs
diff := oldInputs.Diff(news)
if diff == nil {
Expand Down
Loading