Do not patch field managers for Patch resources #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov Report
@@ Coverage Diff @@
## master #2640 +/- ##
==========================================
- Coverage 18.34% 18.33% -0.02%
==========================================
Files 47 47
Lines 9625 9632 +7
==========================================
Hits 1766 1766
- Misses 7760 7767 +7
Partials 99 99
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request addresses the issue where Patch resources unintentionally patch field managers during update operations (ie. when a Patch resource is updated and reused). Such modification results in the Patch resource taking control of all fields managed owned by a field manager with the prefix
kubectl. This, in turn, leads to unintended unset fields when runningpulumi up. Patch resources are designed to contain a specific subset of fields for updating, and they should not interfere with the field managers of normal resources. It's important to note that field managers still need to be patched for regular resources, as they facilitate the transition from Client-Side Apply (CSA) to Server-Side Apply (SSA) for existing Pulumi-managed resources.Additionally, this PR includes a new test to validate this behavior. The test will fail if the logic to avoid field manager patching for Patch resources is not implemented.
Related issues:
Fixes: #2639