Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make the invoke calls for Helm charts and YAML config resilient to the value being None or an empty dict #2665

Merged
merged 7 commits into from
Nov 15, 2023

Commits on Nov 10, 2023

  1. Add Helm regression test

    This is based on the existing `helm-local` test.
    justinvp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a7ea936 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Add YAML regression test

    This is based on the existing `yaml-test` test.
    justinvp committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    bef3889 View commit details
    Browse the repository at this point in the history
  2. Add Kustomize test

    The invoke used for Kustomize was already fixed to be resilient to `None` or empty dicts being returned in a907bdd. This test, which is based on the existing `kustomize` test is to ensure it continues to work without an error being raised.
    justinvp committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9ff8c91 View commit details
    Browse the repository at this point in the history
  3. [sdk/python] Fix invoke to handle empty dicts

    Make the hand-rolled invoke code resilient to `invoke` returning either `None` or an empty dict for empty results. This aligns all invokes with the same pattern as introduced by a907bdd.
    justinvp committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    6b6fee8 View commit details
    Browse the repository at this point in the history
  4. Update CHANGELOG.md

    justinvp committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    55f0e8f View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Address feedback

    justinvp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    767f378 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37219c1 View commit details
    Browse the repository at this point in the history