Fix resource kind lookup using URN.Type instead of QualifiedType #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
blampe
reviewed
Dec 14, 2023
blampe
approved these changes
Dec 14, 2023
rquitales
changed the title
rquitales
force-pushed
the
rquitales/fix-child-patch-rsc
branch
from
12d709a
to
27ffc66
Compare
rquitales
force-pushed
the
rquitales/fix-child-patch-rsc
branch
from
27ffc66
to
876df53
Compare
rquitales
added a commit
that referenced
this pull request
Dec 15, 2023
This pull request uses the URN`Type` method, rather than `QualifiedType` to search if resources are a patch or list resource. Qualified types include the parent resource if there is one, so it would have failed the lookup. Additionally, comprehensive unit tests have been included to validate this change. Fixes: #2718 (manual validation was done to ensure this fix solves this CUJ)
rquitales
added a commit
that referenced
this pull request
Dec 15, 2023
This pull request uses the URN`Type` method, rather than `QualifiedType` to search if resources are a patch or list resource. Qualified types include the parent resource if there is one, so it would have failed the lookup. Additionally, comprehensive unit tests have been included to validate this change. Fixes: #2718 (manual validation was done to ensure this fix solves this CUJ)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request uses the URN
Typemethod, rather thanQualifiedTypeto search if resources are a patch or list resource. Qualified types include the parent resource if there is one, so it would have failed the lookup.Additionally, comprehensive unit tests have been included to validate this change.
Related issues (optional)
Fixes: #2718 (manual validation was done to ensure this fix solves this CUJ)