Use background delete by default; register deletes of CRs correctly #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hausdorff
force-pushed
the
hausdorff/istio-2
branch
from
c6ca8a3
to
fc7e9bd
Compare
hausdorff
changed the title
|
The logic of handling the various errors bubbling out of client-go has started to become very subtle, and resulted in a lot of duplicate code across create/delete/update. This PR is important to allow our partners to make progress (in particular on Istio) so I recommend we ship it, but I think we also need to come back and refactor the way we're passing around the discovery client and the client pool. I've opened an issue to track this work: #281 |
lblackstone
requested changes
Nov 16, 2018
hausdorff
force-pushed
the
hausdorff/istio-2
branch
from
fc7e9bd
to
a485642
Compare
It is possible that if a CRD is deleted after the CR obtains a client for its G/V/K, but before `Watch` is called, that `Watch` will terminate with a 404. This should register as a deletion: if we successfully created that CR before, and it is tracked by Pulumi, but the G/V/K is now unregistered, or the resource is missing, we should consider this a deletion.
hausdorff
force-pushed
the
hausdorff/istio-2
branch
from
a485642
to
4d241a1
Compare
|
@lblackstone any more comments? |
lblackstone
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.