Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chart.v3 previews when cluster is unreachable #2992

Merged
merged 6 commits into from
May 10, 2024
Merged

Conversation

blampe
Copy link
Contributor

@blampe blampe commented May 3, 2024

We currently fail to render a preview for Chart V3 if the cluster is unreachable.

Instead of failing, we can emit a warning since Helm is still able to generate the template without the version set.

Alternatively, we could check k.clusterUnreachable as part of Invoke but we wouldn't be able to return a rich preview.

Added a failing E2E test.

Fixes #2985.

@blampe blampe requested a review from EronWright May 3, 2024 19:14
Copy link

github-actions bot commented May 3, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 29.94%. Comparing base (785d414) to head (a76337a).

❗ Current head a76337a differs from pull request most recent head 0a4e29d. Consider uploading reports for the commit 0a4e29d to get more accurate results

Files Patch % Lines
provider/pkg/provider/invoke_helm_template.go 0.00% 4 Missing ⚠️
provider/pkg/provider/provider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2992      +/-   ##
==========================================
- Coverage   29.99%   29.94%   -0.06%     
==========================================
  Files          63       63              
  Lines        8338     8353      +15     
==========================================
  Hits         2501     2501              
- Misses       5615     5630      +15     
  Partials      222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blampe blampe requested a review from rquitales May 6, 2024 21:21
@blampe blampe merged commit ad58732 into master May 10, 2024
18 checks passed
@blampe blampe deleted the blampe/2985 branch May 10, 2024 22:19
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request May 24, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/kubernetes](https://pulumi.com)
([source](https://togithub.com/pulumi/pulumi-kubernetes)) | dependencies
| minor | [`4.11.0` ->
`4.12.0`](https://renovatebot.com/diffs/npm/@pulumi%2fkubernetes/4.11.0/4.12.0)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pulumi/pulumi-kubernetes (@&#8203;pulumi/kubernetes)</summary>

###
[`v4.12.0`](https://togithub.com/pulumi/pulumi-kubernetes/blob/HEAD/CHANGELOG.md#4120-May-21-2024)

[Compare
Source](https://togithub.com/pulumi/pulumi-kubernetes/compare/v4.11.0...v4.12.0)

##### Added

- Added a new Helm Chart v4 resource.
([pulumi/pulumi-kubernetes#2947)
- Added support for deletion propagation policies (e.g. Orphan).
([pulumi/pulumi-kubernetes#3011)
- Server-side apply conflict errors now include the original field
manager's name.
([pulumi/pulumi-kubernetes#2983)

##### Changed

- Pulumi will now wait for DaemonSets to become ready.
([pulumi/pulumi-kubernetes#2953)
- The Release resource's merge behavior for `valueYamlFiles` now more
closely matches Helm's behavior.
([pulumi/pulumi-kubernetes#2963)

##### Fixed

- Helm Chart V3 previews no longer fail when the cluster is unreachable.
([pulumi/pulumi-kubernetes#2992)
- Fixed a panic that could occur when a missing field became `null`.
([pulumi/pulumi-kubernetes#1970)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzEuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM3MS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create a Helm chart - timeout during pulumi up update preview phase
2 participants