Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious diffs for updates in renderYaml mode #3030

Merged
merged 3 commits into from
May 29, 2024

Conversation

rquitales
Copy link
Contributor

@rquitales rquitales commented May 28, 2024

Proposed changes

Always store newInputs to avoid spurious diffs in renderYaml updates. Storing oldLive in state will result in the Pulumi state never updating after the initial create.

Testing: added a new step within the TestRenderYAML that exercises the update flow. This test fails without the changes in this PR.

Related issues (optional)

Fixes: #3026

@rquitales rquitales force-pushed the rquitales/fix-render-yaml-updates branch from a671a4d to e18a0a9 Compare May 28, 2024 23:49
@rquitales rquitales requested review from blampe, EronWright and a team May 28, 2024 23:50
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 36.43%. Comparing base (41b0d90) to head (e18a0a9).

Files Patch % Lines
provider/pkg/provider/provider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3030   +/-   ##
=======================================
  Coverage   36.43%   36.43%           
=======================================
  Files          70       70           
  Lines        9167     9167           
=======================================
  Hits         3340     3340           
  Misses       5497     5497           
  Partials      330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rquitales rquitales merged commit 4eaacba into master May 29, 2024
20 checks passed
@rquitales rquitales deleted the rquitales/fix-render-yaml-updates branch May 29, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment resource state does not update
2 participants