Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add SkipInstall option for pulumitest tests #3049

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

rquitales
Copy link
Contributor

@rquitales rquitales commented Jun 4, 2024

Proposed changes

This PR explicitly sets the opttest.SkipInstall() option for our yaml tests. It is observed that the test framework/automation API is unable successfully run pulumi install prior to the other pulumi operations. This error was hit in the presubmit for #3046, but went unnoticed in the past due to the TestTerraformConvert installing the right plugins before the other tests hit the installation step.

Manual validation:

  • Deleted the local ~/.pulumi/plugin folder
  • Run the tests without the changes and notice the test errors
  • Run the tests with the changes here and they pass

Related issues (optional)

Fixes: #3048

@rquitales rquitales requested a review from EronWright June 4, 2024 19:35
@EronWright EronWright added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.75%. Comparing base (1100978) to head (f6165e9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
- Coverage   36.77%   36.75%   -0.03%     
==========================================
  Files          71       71              
  Lines        9262     9262              
==========================================
- Hits         3406     3404       -2     
- Misses       5518     5519       +1     
- Partials      338      339       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rquitales rquitales merged commit aad942b into master Jun 4, 2024
17 checks passed
@rquitales rquitales deleted the rquitales/test-yaml branch June 4, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: build
2 participants