Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart v4 should handle an array of assets #3060 #3061

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

EronWright
Copy link
Contributor

Proposed changes

This PR fixes the ValueOpts in pkg/provider/pkg/helm to properly handle arrays of values when expanding
the assets.

New unit test cases were added.

Related issues (optional)

Closes #3060

@EronWright EronWright requested a review from blampe June 13, 2024 23:54
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 36.76%. Comparing base (9333b4d) to head (2c66e11).
Report is 2 commits behind head on master.

Files Patch % Lines
provider/pkg/helm/values.go 76.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
+ Coverage   36.71%   36.76%   +0.04%     
==========================================
  Files          71       71              
  Lines        9262     9269       +7     
==========================================
+ Hits         3401     3408       +7     
- Misses       5521     5523       +2     
+ Partials      340      338       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EronWright EronWright merged commit dc1febf into master Jun 17, 2024
19 checks passed
@EronWright EronWright deleted the issue-3060 branch June 17, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart v4 fails to handle an array of assets
2 participants