Fix buggy ownership logic for Pods in Deployment awaiter #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Deployment awaiter was erroneously overwriting aggregated Pod errors if they had the same name due to buggy ownership checking. Fixed the ownership logic and the relevant tests.
hausdorff
reviewed
Dec 4, 2018
| @@ -459,7 +458,7 @@ func (dia *deploymentInitAwaiter) checkReplicaSetStatus() { | |||
| // we would now have fewer replicas than we had requested in the `Deployment` we last submitted | |||
| // when we last ran `pulumi up`. | |||
| rawSpecReplicas, specReplicasExists := openapi.Pluck(rs.Object, "spec", "replicas") | |||
| specReplicas, _ := rawSpecReplicas.(float64) | |||
| specReplicas, _ := rawSpecReplicas.(int64) | |||
There was a problem hiding this comment.
Hmm, looks like this is actually an *int32? Have we double checked the type with reflect.TypeOf, just to be safe?
There was a problem hiding this comment.
Just checked and it said int64
hausdorff
approved these changes
Dec 4, 2018
|
Bumped the timeout. Yeah, let's output to stdout if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Deployment awaiter was erroneously overwriting aggregated
Pod errors if they had the same name due to buggy ownership checking.
Fixed the ownership logic and the relevant tests.