Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replacement logic in Job #333

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Fix replacement logic in Job #333

merged 1 commit into from
Jan 3, 2019

Conversation

hausdorff
Copy link
Contributor

Fixes #330.

Submitted on behalf of @iagomelanias because our CI system currently does not support external contributors (#332). Previously this PR was #331.

@hausdorff
Copy link
Contributor Author

Per offline conversation with @iagomelanias, we've decided to change the original PR to make .spec.template a force-new property, based on our understanding of the spec, and based on this error we get when you change a property somewhere deep in the Job, as it seems to be saying that .spec.template is an immutable field:

The Job "pi" is invalid: spec.template: Invalid value: core.PodTemplateSpec{...}: field is immutable

@hausdorff hausdorff merged commit 9111610 into master Jan 3, 2019
@pulumi-bot pulumi-bot deleted the iagomelanias/job-await branch January 3, 2019 22:18
@csssuf csssuf mentioned this pull request Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hausdorff @iagomelanias