Handle buggy case for headless Service with no port #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of k8s prior to 1.12.1 have a bug that affects headless Services with no ports specified. These Services do not get Endpoints assigned, which breaks the default awaiter logic. This changeset skips the Pod ready checks for Services affected by this bug.
Regex didn't work for multi-digit numbers.
pbzdyl
reviewed
Jan 23, 2019
|
Hmm, this fixes the bug, but broke unit tests due to a call to ServerVersion (not populated by the test mocks). Working on a fix now. |
hausdorff
suggested changes
Jan 23, 2019
|
Ok, pushed up a change that should fix unit tests, and I'll go back through and pull Patch out of the server version since I ended up not needing it anyway. (I mistakenly thought the bug was fixed in 1.12.1 rather than 1.12.0 initially). |
serverVersion only includes Major.Minor and a separate gitVersion type was created as a fallback option. Added a test for parsing the gitVersion.
|
@hausdorff Could you give this another look? CI failure is related to #375 - will rerun to get a ✅ |
metral
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248