Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mocha to devDependencies to prevent downstream errors #441

Merged
merged 7 commits into from Feb 20, 2019

Conversation

rosskevin
Copy link
Contributor

Closes #440

@lblackstone
Copy link
Member

Hi @rosskevin, thanks for the PR! Can you run make ensure, commit the changes, and resubmit? Note that you'll need the latest version of dep (0.5).

@rosskevin
Copy link
Contributor Author

@lblackstone ran make ensure locally, no changes to commit. It looks like the travis build became non-responsive.

@lblackstone
Copy link
Member

@rosskevin Sorry about the confusion; looks like Travis flaked on the earlier test I looked at. The current failure is because the package.json file is auto-generated from https://github.com/pulumi/pulumi-kubernetes/blob/e4fa04b13a20929c879aca1bbe58fb5a95d16f7c/pkg/gen/nodejs-templates/package.json.mustache

To get this passing, you'll need to update that file to match the changes you made to package.json, and then run make build && make install to rerun the generator code.

@lblackstone lblackstone merged commit 87a9fc8 into pulumi:master Feb 20, 2019
@lblackstone
Copy link
Member

@rosskevin I'll cut an official release later today, but you should be able to get this change with the pulumi/kubernetes: dev package in about 30 mins. Thanks for the quick turnaround!

@rosskevin rosskevin deleted the patch-1 branch February 20, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants