Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable timeouts for complex awaiters #457

Merged
merged 1 commit into from Feb 27, 2019

Conversation

lblackstone
Copy link
Member

Allow the default timeout for each complex awaiter to be
overridden by setting the pulumi.com/timeoutSeconds
annotation.

Fixes #243

Allow the default timeout for each complex awaiter to be
overridden by setting the `pulumi.com/timeoutSeconds`
annotation.
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems here, that the idea is for each component to have its own declared timeout as an annotation. Have we tested this with multiple components who are dependent on each other, each w/ their own timeouts? e.g. A Deployment that depends on a Service, both annotated with differing timeouts?

@lblackstone
Copy link
Member Author

@metral I didn't specifically test it, but the configurable timeout doesn't change the existing semantics. All of these awaiters already have default timeouts set, and the result of a timeout is a reported failure to the CLI. Subsequently running an update/refresh after a timeout would work as usual.

@lblackstone lblackstone merged commit 27e8dc2 into master Feb 27, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/configurable-timeouts branch February 27, 2019 17:27
Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late to the party, but would be nice to have tests for this.

@naveensrinivasan
Copy link

How do we modify the default timeout? I didn't see any doc how to do it?

@lblackstone
Copy link
Member Author

There's currently no way to modify the default timeout, but you can set overrides on individual resources with the timeoutSeconds annotation. See https://blog.pulumi.com/improving-kubernetes-management-with-pulumis-await-logic for example usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to configure timeouts
4 participants