Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML parsing for computed namespaces #483

Merged
merged 4 commits into from
Mar 15, 2019

Conversation

lblackstone
Copy link
Member

This fixes a bug where the provider was incorrectly concatenating
computed namespaces based on the faulty assumption that they
were always a plain string value rather than an Output.

Fixes #478
Fixes #409

Here's an example of the working output:

$ pulumi up --skip-preview
Updating (yaml-url-step1):

     Type                              Name                                  Status
 +   pulumi:pulumi:Stack               guestbook-yaml-url-step1              created
 +   ├─ kubernetes:yaml:ConfigFile     guestbook                             created
 +   │  ├─ kubernetes:core:Service     test-namespace-enbxii7q/frontend      created
 +   │  ├─ kubernetes:core:Service     test-namespace-enbxii7q/redis-slave   created
 +   │  ├─ kubernetes:core:Service     test-namespace-enbxii7q/redis-master  created
 +   │  ├─ kubernetes:apps:Deployment  test-namespace-enbxii7q/redis-master  created
 +   │  ├─ kubernetes:apps:Deployment  test-namespace-enbxii7q/redis-slave   created
 +   │  └─ kubernetes:apps:Deployment  test-namespace-enbxii7q/frontend      created
 +   └─ kubernetes:core:Namespace      test-namespace                        created

Resources:
    + 9 created

Duration: 14s

This fixes a bug where the provider was incorrectly concatenating
computed namespaces based on the faulty assumption that they
were always a plain string value rather than an Output<string>.
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lblackstone lblackstone merged commit 78d7c54 into master Mar 15, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/nodejs-yaml-fix branch March 15, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yaml-url test has broken names Resource IDs are incorrect for computed namespaced resources
3 participants