Add transforms to YAML support for Python SDK #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/python-yaml-transforms
branch
5 times, most recently
from
d73e209
to
fc9f820
Compare
lblackstone
changed the title
hausdorff
reviewed
Apr 1, 2019
| # Allow users to change API objects before any validation. | ||
| if transformations is not None: | ||
| for t in transformations: | ||
| obj = t(obj) |
There was a problem hiding this comment.
Reading this code now, I realize that we're running the transformations before we unpack the lists of resources, both here and in the nodejs SDK. I think we want to do the opposite? Perhaps not in this PR but in the future.
| name="guestbook", | ||
| file_id="https://raw.githubusercontent.com/pulumi/pulumi-kubernetes/master/tests/examples/yaml-guestbook/yaml" | ||
| "/guestbook.yaml", | ||
| transformations=[add_namespace], |
There was a problem hiding this comment.
I believe we are not verifying that this namespace is actually added in the test harness? Can we do that?
lblackstone
force-pushed
the
lblackstone/python-yaml-transforms
branch
from
937202f
to
e295ae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325