Put all resources in specified provider namespace #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hausdorff
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
I'm going to go ahead and approve this, but we should test it pretty extensively before shipping.
If I'm not mistaken, this is very close to a solution for #217, right? To solve that, we basically have to be able to pass along the namespace as a part of the Create/Update RPC calls, and then we just need to consult the same NamespacedKind here to decide to override the namespace, right?
|
@hausdorff Right, it should be pretty straightforward to fix 217 from this change as well. |
lblackstone
force-pushed
the
lblackstone/provider-namespace
branch
from
17f0788
to
3bb5e12
Compare
hausdorff
added
the
impact/breaking
lblackstone
added a commit
that referenced
this pull request
Apr 5, 2019
This reverts commit 5204b3b.
lblackstone
added a commit
that referenced
this pull request
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #415
Reviewer notes / points of discussion: