Fix Deployment await logic for old API schema #523
Conversation
Resources created with the old extensions/v1beta1:Deployment schema do not include two status fields that the await logic was expecting. Add an exception for this API version to make those checks pass.
There was a problem hiding this comment.
This is ok to unblock people, but it looks to me that we're (1) not checking that the new RS has become available, and (2) not checking the Progressing status (which doesn't exist) -- in my estimation this removes entirely the await logic for Deployments declared with version extensions/v1beta1.
Can we file a follow-up issue to try to do something smarter here?
Also, note that we cannot simply use the Kubernetes schema auto-translation -- if declared as extensions/v1beta1 even kubectl get'ing the .status field does not actually cause these fields to appear. This sucks, and effectively means that we'll have to have a parallel await logic path for this specific API version. Worth nothing that in the issue.
|
One other thing -- does the bug described in #519 also happen in |
Those both work as usual; no changes required. |
The extensions/v1beta1 version of Deployment uses a different code path because it doesn't include all of the fields we use to check readiness on newer apiVersions. This logic was updated in #523, but introduced a different bug in the process. The logic should now correctly check for readiness across all Deployment apiVersions.
The extensions/v1beta1 version of Deployment uses a different code path because it doesn't include all of the fields we use to check readiness on newer apiVersions. This logic was updated in #523, but introduced a different bug in the process. The logic should now correctly check for readiness across all Deployment apiVersions.
The extensions/v1beta1 version of Deployment uses a different code path because it doesn't include all of the fields we use to check readiness on newer apiVersions. This logic was updated in #523, but introduced a different bug in the process. The logic should now correctly check for readiness across all Deployment apiVersions.
Resources created with the old extensions/v1beta1:Deployment schema
do not include two status fields that the await logic was expecting. Add
an exception for this API version to make those checks pass.
Fixes #519