Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Helm repo quoting for Windows #540

Merged
merged 4 commits into from Apr 18, 2019
Merged

Fix Helm repo quoting for Windows #540

merged 4 commits into from Apr 18, 2019

Conversation

lblackstone
Copy link
Member

Fixes #539

hausdorff
hausdorff approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we've actually tested this on Windows and on Unix, I think it's fine to ship this. If not, we should.

@lblackstone lblackstone merged commit 4b01b51 into master Apr 18, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/helm-repo-bug branch April 18, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hausdorff hausdorff hausdorff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm repo arg doesn't work on Windows
2 participants
@lblackstone @hausdorff