Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm support to Python SDK #544

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Add Helm support to Python SDK #544

merged 2 commits into from
Apr 30, 2019

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Apr 25, 2019

Notes:
This includes a required fix from unmerged PR #545
I'll add more extensive tests later. Right now, this just smoke tests the Chart creation.

Fixes #464

@ericrudder
Copy link
Member

ericrudder commented Apr 25, 2019 via email

@lblackstone lblackstone marked this pull request as ready for review April 26, 2019 18:25
Copy link
Contributor

@swgillespie swgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits/questions.

@lblackstone lblackstone merged commit 6c4b212 into master Apr 30, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/python-helm branch April 30, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add k8s.helm.* support to Python SDK
3 participants