Fix namespaceable check for diff #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For deployments that rely on CRDs created by a controller, it is not possible to tell if the related CR is namespaceable during preview or diff. The diff case was overlooked in the previous fix for preview. Rather than returning an error, assume that the CR is namespaceable, and correct during the Create if required.
hausdorff
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For deployments that rely on CRDs created by a controller,
it is not possible to tell if the related CR is namespaceable
during preview or diff. The diff case was overlooked in the
previous fix for preview. Rather than returning an error,
assume that the CR is namespaceable, and correct during
the Create if required.
Fixes #553