Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate provider logs #558

Merged
merged 1 commit into from
May 10, 2019
Merged

Deduplicate provider logs #558

merged 1 commit into from
May 10, 2019

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented May 8, 2019 •
edited
Loading

Fixes #518

awaiters to update

  • Deployment
  • StatefulSet
  • Pod
  • Service
  • Ingress

@lblackstone lblackstone force-pushed the lblackstone/log-cleanup branch 2 times, most recently from 585c921 to 2aecd32 Compare May 8, 2019 17:50
metral
metral reviewed May 9, 2019
View reviewed changes
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments to think on. Thanks for removing the batching, that made this PR easier to review - given that this PR is only dedup'ing logs now, we should update the title as well.

pkg/logging/logger.go Outdated Show resolved Hide resolved
pkg/logging/time_ordered_log_set.go Outdated Show resolved Hide resolved
pkg/logging/time_ordered_log_set_test.go Outdated Show resolved Hide resolved
@lblackstone lblackstone changed the title Deduplicate and batch provider logs Deduplicate provider logs May 9, 2019
hausdorff
hausdorff suggested changes May 9, 2019
View reviewed changes
Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some misc. thoughts:

  • Instead of changing all the call sites of createAwaitConfig#logStatus to config.logger.LogMessage, it seems like we could just change logStatus to log to the Logger itself. Seems like it would cut the diff down significantly?

pkg/logging/logger.go Outdated Show resolved Hide resolved
pkg/logging/logger.go Outdated Show resolved Hide resolved
pkg/logging/logger.go Outdated Show resolved Hide resolved
pkg/logging/logger.go Outdated Show resolved Hide resolved
pkg/logging/time_ordered_log_set.go Outdated Show resolved Hide resolved
pkg/logging/logger.go Outdated Show resolved Hide resolved
@lblackstone lblackstone requested a review from hausdorff May 9, 2019 23:20
@lblackstone lblackstone merged commit 75e00de into master May 10, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/log-cleanup branch May 10, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metral metral metral approved these changes

@hausdorff hausdorff hausdorff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive log messages
3 participants
@lblackstone @metral @hausdorff