Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getInputs from Kubernetes resources #580

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Conversation

hausdorff
Copy link
Contributor

No description provided.

`getInputs` was originally implemented before the Pulumi engine had
parallelism, and before the Kubernetes SDKs used `pulumi.Input`. The
reason for this was to allow Kuberentes objects, which are normally
well-decoupled, to reference each other without taking a dependency on
one another, avoiding the case where there is a circular dependency
(and, hence, a deadlock in updates).

This commit removes this unnecessary field.
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Is there a related open issue?

@hausdorff
Copy link
Contributor Author

It's related to #566 but it does not come close to fixing it.

@hausdorff hausdorff merged commit 8a681f2 into master Jun 3, 2019
@pulumi-bot pulumi-bot deleted the hausdorff/inputs branch June 3, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants