Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change provider namespace from override to default #585

Merged
merged 4 commits into from
Jun 5, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
## 0.23.2 (Unreleased)

### Important

This release changes the behavior of the provider namespace flag introduced in `0.23.0`.
Previously, this flag was treated as an override, which ignored namespace values set
directly on resources. Now, the flag is a default, and will only set the namespace if one
is not already set. **This may cause resources to be recreated!**

lblackstone marked this conversation as resolved.
Show resolved Hide resolved
### Major changes

- BREAKING: Change the recently added `transformations` callback in Python to match JavaScript API (https://github.com/pulumi/pulumi-kubernetes/pull/575)
Expand Down
1 change: 1 addition & 0 deletions sdk/nodejs/provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export interface ProviderArgs {
readonly kubeconfig?: pulumi.Input<string>;
/**
* If present, the default namespace to use. This flag is ignored for cluster-scoped resources.
lblackstone marked this conversation as resolved.
Show resolved Hide resolved
* Note: if .metadata.namespace is set on a resource, that value takes precedence over the provider default.
*/
readonly namespace?: pulumi.Input<string>;
}
2 changes: 2 additions & 0 deletions sdk/python/pulumi_kubernetes/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ def __init__(self,
If this is set, this config will be used instead of $KUBECONFIG.
:param pulumi.Input[str] namespace: If present, the default namespace to use.
This flag is ignored for cluster-scoped resources.
Note: if .metadata.namespace is set on a resource, that value takes
precedence over the provider default.
"""
__props__ = {
"cluster": cluster,
Expand Down