Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional resourcePrefix param for Chart #599

Merged
merged 9 commits into from
Jun 20, 2019

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Jun 18, 2019

Allow users to disambiguate resources generated from a helm
Chart using the optional resourcePrefix parameter. If set, the
generated resources will be prefixed with the provided string.

Fixes #520

Allow users to disambiguate resources generated from a helm
Chart using the optional `resourcePrefix` parameter. If set, the
generated resources will be prefixed with the provided string.
@lblackstone lblackstone force-pushed the lblackstone/disambiguate-helm-names branch from c1cf51d to 1b8a3b8 Compare June 19, 2019 19:40
@lblackstone lblackstone requested a review from metral June 19, 2019 23:36
pkg/gen/python-templates/helm/v2/helm.py Show resolved Hide resolved
tests/examples/examples_test.go Show resolved Hide resolved
tests/examples/helm-local/index.ts Outdated Show resolved Hide resolved
tests/examples/python/python_test.go Show resolved Hide resolved
tests/examples/python/python_test.go Outdated Show resolved Hide resolved
tests/integration/yaml-url/step1/index.ts Outdated Show resolved Hide resolved
@lblackstone lblackstone requested a review from metral June 20, 2019 17:20
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

self.transformations = transformations
self.resource_prefix = resource_prefix


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rm extra line

@lblackstone lblackstone merged commit 4e61e0d into master Jun 20, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/disambiguate-helm-names branch June 20, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate resource URN with helm when using same release name on multiple clusters
2 participants