Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more props that force replacement of Pods #613

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Add more props that force replacement of Pods #613

merged 1 commit into from
Jul 1, 2019

Conversation

lblackstone
Copy link
Member

Fixes #612

@lblackstone lblackstone force-pushed the lblackstone/pod-replace-props branch from 7671c44 to fca34bf Compare June 26, 2019 16:12
@ellismg
Copy link
Contributor

ellismg commented Jun 26, 2019

For my own edification - How did you determine what the list of properties that forced replacement were?

@lblackstone
Copy link
Member Author

@ellismg I used the API reference and listed everything not mentioned in the error message doc'd in #612

@lblackstone lblackstone force-pushed the lblackstone/pod-replace-props branch from fca34bf to 5c21900 Compare June 27, 2019 19:37
ellismg
ellismg approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for teaching me how you did this!

@lblackstone lblackstone merged commit f1a6f90 into master Jul 1, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/pod-replace-props branch July 1, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellismg ellismg ellismg approved these changes

@hausdorff hausdorff Awaiting requested review from hausdorff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing .spec.restartPolicy should force Pod replacement
2 participants
@lblackstone @ellismg