Return a detailed diff from Diff. #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add support for detailed diffs to the Kubernetes provider. The detailed diff is calculated by computing a JSON merge patch between the desired and new state, recursively walking the result, and recording the difference at each leaf property as indicated by the patch. The particular difference that is recorded for a property depends on the old and new values: - If the patched value is nil, the property is recorded as deleted - If the old value is nil, the property is recorded as added - If the types of the old and new values differ, the property is recorded as updated - If both values are maps, the maps are recursively compared on a per-property basis and added to the diff - If both values are arrays, the arrays are recursively compared on a per-element basis and added to the diff - If both values are primitives and the values differ, the property is recorded as updated - Otherwise, no diff is recorded. If a difference is present at a path and the path matches one of the patterns in the database of force-new properties, the diff is amended to indicate that the resource needs to be replaced due to the change in this property.
lblackstone
requested changes
Jul 3, 2019
Co-Authored-By: Levi Blackstone <levi@pulumi.com>
Co-Authored-By: Levi Blackstone <levi@pulumi.com>
Co-Authored-By: Levi Blackstone <levi@pulumi.com>
|
Looks like the Istio test failed. @lblackstone can you help me interpret the output? It looks like the failure is unrelated, but I'm not sure. |
|
@pgavlin Yeah, it looks like a couple of the Pods failed to start for some reason, so it's probably a flake. I restarted the job. |
lblackstone
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add support for detailed diffs to the Kubernetes provider.
The detailed diff is calculated by computing a JSON merge patch between
the desired and new state, recursively walking the result, and recording
the difference at each leaf property as indicated by the patch.
The particular difference that is recorded for a property depends on the
old and new values:
as updated
per-property basis and added to the diff
per-element basis and added to the diff
recorded as updated
If a difference is present at a path and the path matches one of the
patterns in the database of force-new properties, the diff is amended to
indicate that the resource needs to be replaced due to the change in
this property.