Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to Pod await PR feedback #626

Merged
merged 7 commits into from
Jul 23, 2019
Merged

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Jul 9, 2019

Addressing feedback from #590

- Load fixtures from JSON files
- Create directory structure for fixtures
- Update tests to reference new fixtures
@lblackstone lblackstone added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jul 9, 2019
Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol I've always hated that image pull error message.

@lblackstone lblackstone merged commit d714b27 into master Jul 23, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/pod-await-feedback branch July 23, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants