Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't render emoji on Windows. #634

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Don't render emoji on Windows. #634

merged 1 commit into from
Jul 16, 2019

Conversation

hausdorff
Copy link
Contributor

@hausdorff hausdorff commented Jul 13, 2019 •
edited
Loading

Fixes #159.

@hausdorff hausdorff changed the title Don't render emoji on Windows. Fixes #159. Don't render emoji on Windows. Jul 13, 2019
pgavlin
pgavlin approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM otherwise

pkg/await/apps_deployment.go Outdated Show resolved Hide resolved
@hausdorff hausdorff merged commit ba82314 into master Jul 16, 2019
@pulumi-bot pulumi-bot deleted the hausdorff/emoji branch July 16, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin approved these changes

@lblackstone lblackstone Awaiting requested review from lblackstone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkmarks during Updates don't render on Windows
2 participants
@hausdorff @pgavlin