Emit useful error when kubernetes:config:kubeconfig fails to parse
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hausdorff
force-pushed
the
hausdorff/kc-parse-error
branch
3 times, most recently
from
2efc422
to
d7832ce
Compare
pgavlin
approved these changes
Jul 15, 2019
| @@ -234,7 +234,9 @@ func (k *kubeProvider) Configure(_ context.Context, req *pulumirpc.ConfigureRequ | |||
| if configJSON, ok := vars["kubernetes:config:kubeconfig"]; ok { | |||
| config, err := clientcmd.Load([]byte(configJSON)) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to parse kubeconfig: %v", err) | |||
| return nil, pkgerrors.Wrap(err, "failed to parse kubeconfig data in "+ | |||
There was a problem hiding this comment.
Does a YAML literal work here as well as JSON? Also, the wording is a bit informal; I'd kill "and not (say) a filename".
There was a problem hiding this comment.
Updated the wording, but I think it's fine to not bother to clarify that JSON is a strict subset of YAML because (1) "YAML" in the k8s ecosystem is used, basically, as shorthand for "JSON or YAML", (20 I've actually never seen someone write kubeconfig in JSON (3) if you do, kubectl auto-converts it to YAML the first time it changes it for any reason, and (4) the ecosystem, IME, largely understands that JSON is a subset of YAML anyway.
hausdorff
force-pushed
the
hausdorff/kc-parse-error
branch
from
d7832ce
to
1e44871
Compare
hausdorff
force-pushed
the
hausdorff/kc-parse-error
branch
from
1e44871
to
967d1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209.