Use dry-run in Diff when available. #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes update `Diff` to calculate the new state for the patched resource by requesting that the API server dry-run the patch when possible. This avoids unexpected diffs due to server-side normalization of values that are present in both the resource's configuration and its state. Fixes #644.
pgavlin
commented
Jul 23, 2019
lblackstone
approved these changes
Jul 24, 2019
Co-Authored-By: Levi Blackstone <levi@pulumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes update
Diffto calculate the new state for the patchedresource by requesting that the API server dry-run the patch when
possible. This avoids unexpected diffs due to server-side normalization
of values that are present in both the resource's configuration and its
state.
Fixes #644.