Fix Deployment await logic for extensions/v1beta1 #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Deployment await logic was not correctly checking rollout success for the `extensions/v1beta1` apiVersion, which was causing the await logic to erroneously pass for change triggered rollouts, even if the Deployment was invalid. Added additional logic to the readiness check based on status fields present in all apiVersions.
hausdorff
reviewed
Jul 29, 2019
hausdorff
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Deployment await logic was not correctly checking rollout
success for the
extensions/v1beta1apiVersion, which wascausing the await logic to erroneously pass for change
triggered rollouts, even if the Deployment was invalid.
Added additional logic to the readiness check based on
status fields present in all apiVersions.
Fixes #611
Fixes #656