Return to diffing inputs for resources w/o dry run. #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to normalization performed by the API server, the recent changes to use a kubectl-style merge patch approach when diffing resources often results in spurious diffs. This interacts particularly badly with resources like `Secret` where the spurious diffs cause unnecessary resource replacements. These changes return to the earlier input-based diff logic for resources and/or API servers that do not support dry-run. Fixes #653.
hausdorff
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to normalization performed by the API server, the recent changes to
use a kubectl-style merge patch approach when diffing resources often
results in spurious diffs. This interacts particularly badly with
resources like
Secretwhere the spurious diffs cause unnecessaryresource replacements. These changes return to the earlier input-based
diff logic for resources and/or API servers that do not support dry-run.
Fixes #653.