Fix values arg for Python Helm SDK #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is based on the namespace arg fix, which hasn't merged yet. The relevant portion of this PR is just the values arg commit. |
ellismg
reviewed
Jul 31, 2019
lblackstone
force-pushed
the
lblackstone/python-helm-values-unwrap
branch
from
738c678
to
21dde68
Compare
Previously, this code was not unwrapping the Output properly for dynamic values.
lblackstone
force-pushed
the
lblackstone/python-helm-values-unwrap
branch
from
21dde68
to
198c2fa
Compare
hausdorff
approved these changes
Aug 2, 2019
|
I need to caveat this approval with: I do not know python extremely well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #677